Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot clean terminal with keybindings anymore #6916

Closed
akosyakov opened this issue Jan 20, 2020 · 6 comments · Fixed by #6934
Closed

cannot clean terminal with keybindings anymore #6916

akosyakov opened this issue Jan 20, 2020 · 6 comments · Fixed by #6934
Assignees
@vinokurig
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help keybindings issues related to keybindings Team: Che-Plugins issues related to the che-plugins team terminal issues related to the terminal

Comments

@akosyakov
Copy link
Member

Screen Shot 2020-01-20 at 12 03 04

Keybinding service waits for next chord. Caused by changes in this line: 582ae9d#diff-0291e1b92ff01c13c0dc1c98263ac426R631

cc @vinokurig
@akosyakov akosyakov added bug bugs found in the application terminal issues related to the terminal keybindings issues related to keybindings labels Jan 20, 2020
@akosyakov
Copy link
Member Author

akosyakov commented Jan 20, 2020 •
edited
Loading

That's possibly critical if none of terminal keybinding are working anymore. I suggest we revert this line and someone else will need to look into support of emacs vscode extension without breaking terminals again.

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jan 20, 2020
@vinokurig vinokurig self-assigned this Jan 20, 2020
@vinokurig
Copy link
Contributor

I am working on it.

@azatsarynnyy azatsarynnyy added the Team: Che-Plugins issues related to the che-plugins team label Jan 20, 2020
@ericwill ericwill mentioned this issue Jan 20, 2020
Closed
16 tasks
@akosyakov
Copy link
Member Author

@vinokurig ok, do you have estimation when it can be fixed?

@vinokurig
Copy link
Contributor

@akosyakov I am going to open a PR today

@akosyakov
Copy link
Member Author

@vinokurig how are you going to fix it? I was thinking try to check whether there is at least one partial keybinding which is active, i.e. its context/when closure evaluates to true, instead of checking only for existence.

@vinokurig vinokurig mentioned this issue Jan 21, 2020
Merged
1 task
@vinokurig
Copy link
Contributor

@akosyakov The PR is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
bug bugs found in the application help wanted issues meant to be picked up, require help keybindings issues related to keybindings Team: Che-Plugins issues related to the che-plugins team terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keybinding check in case when full and partial bindings are registered eclipse-theia/theia
3 participants
@azatsarynnyy @akosyakov @vinokurig