Add keybinding check in case when full and partial bindings are registered

[vinokurig]

What it does

If full and partial keybindings are registered for the same key sequence, apply the keybinding which has higher priority.

fixes #6916

How to test

Perform some actions in terminal, then execute ctrl + k.
See: terminal content is cleared.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@vinokurig does vs code has the same meaning of priority by scopes? Or it’s just rely on order and when closure to figure out the higher priority?

Do we need to test emacs extension? I.e. to make sure that the original issue for which check was introduced is still resolved

[vinokurig]

@akosyakov

does vs code has the same meaning of priority by scopes? Or it’s just rely on order and when closure to figure out the higher priority?

Vscode has a single collection where full and partial keybindings are placed and the first item that matches context corresponds to key sequence

Do we need to test emacs extension? I.e. to make sure that the original issue for which check was introduced is still resolved

I've tested the emacs extension and didn't found any regression

[akosyakov]

Vscode has a single collection where full and partial keybindings are placed and the first item that matches context corresponds to key sequence

It would mean that they will have the same issue with the terminal? I just wonder whether we need to introduce scope, should not be filtering of keybindings which are not enabled be enough?

[vinokurig]

They don't have this issue because the list of keybindings is properly sorted. I suppose they use priorities in the step of collecting the list of keybindings: https://github.com/microsoft/vscode/blob/e7f559cd3b3127347203b1ef4e801689ca96f45e/src/vs/platform/keybinding/common/keybindingResolver.ts#L78-L102

[akosyakov]

the list of keybindings is properly sorted

@vinokurig By that you mean that defaults comes before overrides, correct?

[vinokurig]

yes

[akosyakov]

It works for me now, thank you @vinokurig