Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firefox] incorrect display of workspace settings file icon #6990

Closed
vince-fugnitto opened this issue Jan 29, 2020 · 1 comment · Fixed by #7011
Closed

[firefox] incorrect display of workspace settings file icon #6990

vince-fugnitto opened this issue Jan 29, 2020 · 1 comment · Fixed by #7011
Labels
browser/firefox issues related to the firefox browser help wanted issues meant to be picked up, require help preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Description

The workspace settings.json file displayed in the tab when using the preferences view is incorrectly displayed (the file icon is too large) when using the application on Firefox.

Screen Shot 2020-01-28 at 7 24 59 PM

Steps to Reproduce

  1. start the application on Firefox with a workspace (ex: theia)
  2. open the preferences widget
  3. notice the workspace tab's icon is displayed too large
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help preferences issues related to preferences browser/firefox issues related to the firefox browser labels Jan 29, 2020
@vince-fugnitto vince-fugnitto changed the title [firefox] incorrect display of workspace settings file [firefox] incorrect display of workspace settings file icon Jan 29, 2020
@Anasshahidd21 Anasshahidd21 mentioned this issue Jan 29, 2020
Closed
1 task
vince-fugnitto added a commit that referenced this issue Jan 29, 2020
@vince-fugnitto
[preferences] fix the display of file icons
df90c0e 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Jan 29, 2020
Merged
3 tasks
vince-fugnitto added a commit that referenced this issue Jan 29, 2020
@vince-fugnitto
[preferences] fix the display of file icons
8978961 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Jan 30, 2020
@vince-fugnitto
[preferences] fix the display of file icons
55a5ce9 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Feb 1, 2020
@vince-fugnitto
[preferences] fix the display of file icons
b53cfca 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@elaihau
Copy link
Contributor

elaihau commented Feb 3, 2020

i can also reproduce it in latest Chrome

vince-fugnitto added a commit that referenced this issue Feb 4, 2020
@vince-fugnitto
[preferences] fix the display of file icons
3d5443b 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Feb 4, 2020
@vince-fugnitto
[preferences] fix the display of file icons
5305211 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
@vince-fugnitto
[preferences] fix the display of file icons
213ad77 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
@vince-fugnitto
[preferences] fix the display of file icons
44aa52f 
Fixes #6990
Fixes #7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
[preferences] fix the display of file icons
1208e36 
Fixes eclipse-theia#6990
Fixes eclipse-theia#7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@vince-fugnitto
[preferences] fix the display of file icons
4dab668 
Fixes eclipse-theia#6990
Fixes eclipse-theia#7010

- fixes an issue where the file icon was not properly displayed
- fixes an issue where the file icon was not properly updated
based on the current file icon theme. This problem is solved by
programmatically getting the icon based on the `file-icon` using
the `labelProvider#getIcon` method.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser/firefox issues related to the firefox browser help wanted issues meant to be picked up, require help preferences issues related to preferences
Projects
None yet
Milestone
No milestone
2 participants
@elaihau @vince-fugnitto