Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amending without previous commit fails silently #7032

Closed
JonasHelming opened this issue Jan 31, 2020 · 2 comments
Closed

Amending without previous commit fails silently #7032

JonasHelming opened this issue Jan 31, 2020 · 2 comments
Labels
git issues related to git

Comments

@JonasHelming
Copy link
Contributor

Description

If you amend a comit to a repository, which does not have any previous commits, the operation silently fails (errors are logged on the console)

Reproduction Steps

Init a git repo, amend a change

OS and Theia version: latest

I will provide a fix...
JonasHelming added a commit to eclipsesource/theia that referenced this issue Jan 31, 2020
@JonasHelming
Amending without previous commit fails eclipse-theia#7032
e3db67f 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

#7033

@vince-fugnitto vince-fugnitto added the git issues related to git label Jan 31, 2020
westbury pushed a commit that referenced this issue Feb 3, 2020
@JonasHelming @westbury
Amending without previous commit fails #7032
cc0da4e 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming
Copy link
Contributor Author

PR is merged...

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@JonasHelming @akosyakov
Amending without previous commit fails eclipse-theia#7032
0d15ef0 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@JonasHelming
Amending without previous commit fails eclipse-theia#7032
1edfa18 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git issues related to git
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonasHelming @vince-fugnitto