Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Host swallows PREFIX_THEIA_SUFFIX Env Vars #7084

Closed
AlexTugarev opened this issue Feb 5, 2020 · 2 comments · Fixed by #7085
Closed

Plugin Host swallows PREFIX_THEIA_SUFFIX Env Vars #7084

AlexTugarev opened this issue Feb 5, 2020 · 2 comments · Fixed by #7085
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@AlexTugarev
Copy link
Contributor

If it's not doing any harm I propose to change the regex for filtering of Env Var to be passed on to the plugin host to mach for ^THEIA_ instead fo THEIA_, cf.

theia/packages/core/src/node/messaging/ipc-protocol.ts

Line 48 in a0e1fd2

const THEIA_ENV_REGEXP_EXCLUSION = new RegExp('THEIA_*');

The use case is the debug console where we miss some of the Env Vars.
@AlexTugarev AlexTugarev added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Feb 5, 2020
@AlexTugarev
Copy link
Contributor Author

@akosyakov and @tolusha, what do you think about this?

AlexTugarev added a commit that referenced this issue Feb 5, 2020
@AlexTugarev
[plugin-host] change THEIA_ env exclusion filter
bb81e19 
to match `^THEIA_` instead of `THEIA_`. this allows to access `PREFIX_THEIA_SUFFIX` env vars in plug-ins.

Fixes #7084
@AlexTugarev AlexTugarev mentioned this issue Feb 5, 2020
Merged
1 task
@benoitf
Copy link
Contributor

benoitf commented Feb 5, 2020

I think it was the original intent/idea

AlexTugarev added a commit that referenced this issue Feb 5, 2020
@AlexTugarev
[plugin-host] change THEIA_ env exclusion filter
6e1b955 
to match `^THEIA_` instead of `THEIA_`. this allows to access `PREFIX_THEIA_SUFFIX` env vars in plug-ins.

Fixes #7084
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@AlexTugarev @akosyakov
[plugin-host] change THEIA_ env exclusion filter
f443b9f 
to match `^THEIA_` instead of `THEIA_`. this allows to access `PREFIX_THEIA_SUFFIX` env vars in plug-ins.

Fixes eclipse-theia#7084
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@AlexTugarev
[plugin-host] change THEIA_ env exclusion filter
7ad939e 
to match `^THEIA_` instead of `THEIA_`. this allows to access `PREFIX_THEIA_SUFFIX` env vars in plug-ins.

Fixes eclipse-theia#7084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin-host] change THEIA_ env exclusion filter eclipse-theia/theia
2 participants
@benoitf @AlexTugarev