Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsx: update extension information in the extension-editor #7434

Closed
vince-fugnitto opened this issue Mar 27, 2020 · 8 comments · Fixed by #7439
Closed

vsx: update extension information in the extension-editor #7434

vince-fugnitto opened this issue Mar 27, 2020 · 8 comments · Fixed by #7439
Labels
ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Mar 27, 2020

Description

There are some key differences between our extension headers, and that of vscode, namely:

  • we include a globe icon (not sure as to what the reason might be - perhaps global install?)
  • the alignment of items in the header are different than vscode (harder to read, inconsistent)
  • we omit data, for example the license field (brackets has a license in open-vsx but none is shown in the editor): improve license detection for built-in extensions #7381
  • font-weight of action items are inconsistent

Theia

Screen Shot 2020-03-27 at 10 50 14 AM

VS Code

Screen Shot 2020-03-27 at 10 56 15 AM
@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration labels Mar 27, 2020
@vince-fugnitto
Copy link
Member Author

@kaiyue0329 would you like to address the issue?

@vince-fugnitto
Copy link
Member Author

The license bug might be related to:

@akosyakov
Copy link
Member

we include a globe icon (not sure as to what the reason might be - perhaps global install?)

global means that namespace is not claimed and anyone can publish, please read tooltip on hover

@akosyakov
Copy link
Member

we omit data, for example the license field (brackets has a license in open-vsx but none is shown in the editor)

Because of #7381?

@vince-fugnitto
Copy link
Member Author

we include a globe icon (not sure as to what the reason might be - perhaps global install?)

global means that namespace is not claimed and anyone can publish, please read tooltip on hover

I was wondering it it made sense for end-users to see this info?
I understand it is present in the open-vsx, but is it useful for end-users?

@vince-fugnitto
Copy link
Member Author

we omit data, for example the license field (brackets has a license in open-vsx but none is shown in the editor)

Because of #7381?

Right, I mentioned it #7434 (comment)

@akosyakov
Copy link
Member

I understand it is present in the open-vsx, but is it useful for end-users?

Yes, it is important that one who instals was aware that an extension is not published by verified author but by some person on the internet.

@vince-fugnitto
Copy link
Member Author

I understand it is present in the open-vsx, but is it useful for end-users?

Yes, it is important that one who instals was aware that an extension is not published by verified author but by some person on the internet.

Thank you for clarifying for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants