Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks dependency resolution does not work as in VS Code #7514

Open
tsmaeder opened this issue Apr 7, 2020 · 2 comments
Open

Tasks dependency resolution does not work as in VS Code #7514

tsmaeder opened this issue Apr 7, 2020 · 2 comments
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Apr 7, 2020

Configure some task, for example:

"tasks": [
        {
            "type": "npm",
            "script": "build",
            "group": "build",
            "problemMatcher": [],
            "dependsOn": ["npm: clean"]
        }
    ]

If you now execute the Run Task... command and choose the npm: build task, VS Code starts to execute the contributed task labeled npm: clean.

If I do the same in Theia, the npm build task is executed without starting the npm: clean task.

@tsmaeder tsmaeder added bug bugs found in the application tasks issues related to the task system labels Apr 7, 2020
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Apr 7, 2020
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 7, 2020

Not sure this should have the 'vscode' label: unless I don't understand how to reference dependent tasks, this is not just the same as in VS Code, it's broken.

@elaihau
Copy link
Contributor

elaihau commented Apr 16, 2020

looks like the dependsOn is not even supported for detected tasks in theia.

elaihau added a commit that referenced this issue Apr 26, 2020
- all detected tasks are associated with unique IDs (https://github.com/eclipse-theia/theia/blob/bda9ff9d4cf15b28b5ffc2e984f11834adfc8f33/packages/plugin-ext/src/plugin/types-impl.ts#L1786-L1800). This pull request adds the "id" property to the ContributedTaskConfiguration interface.

- fixes #7514

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Apr 26, 2020
- all detected tasks are associated with unique IDs (https://github.com/eclipse-theia/theia/blob/bda9ff9d4cf15b28b5ffc2e984f11834adfc8f33/packages/plugin-ext/src/plugin/types-impl.ts#L1786-L1800). This pull request adds the "id" property to the ContributedTaskConfiguration interface.

- fixes #7514

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants