Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

references-view.tree does not work anymore #7621

Closed
akosyakov opened this issue Apr 20, 2020 · 1 comment · Fixed by #7626
Closed

references-view.tree does not work anymore #7621

akosyakov opened this issue Apr 20, 2020 · 1 comment · Fixed by #7626
Assignees
@akosyakov
Labels
bug bugs found in the application critical critical bugs / problems vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

It's a regression. To reproduce use Find All References or Find All Implementations.
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Apr 20, 2020
@akosyakov akosyakov self-assigned this Apr 20, 2020
@akosyakov akosyakov added the critical critical bugs / problems label Apr 20, 2020
@akosyakov
Copy link
Member Author

We removed Monaco conversion by the mistake: f691918#diff-f64a29836bb4f06980438d7060ff1e5dL285-L286

I will send a PR. cc @JPinkney

akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
add integration test to reproduce #7621 regressions
880d0c8 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
fix #7621: add missing vscode.execute command mappings
1807f22 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Apr 20, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
add integration test to reproduce #7621 regressions
a01ae23 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
fix #7621: add missing vscode.execute command mappings
1c3aa60 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
add integration test to reproduce #7621 regressions
615a4fc 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
fix #7621: add missing vscode.execute command mappings
e1c2f20 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
add integration test to reproduce #7621 regressions
2140a41 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
fix #7621: add missing vscode.execute command mappings
c66f94d 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
add integration test to reproduce #7621 regressions
7c82826 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Apr 20, 2020
@akosyakov
fix #7621: add missing vscode.execute command mappings
7d56c34 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application critical critical bugs / problems vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #7621: add missing vscode.execute command mappings eclipse-theia/theia
1 participant
@akosyakov