Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code debuggers using resolveDebugConfigurationWithSubstitutedVariables do not launch #7690

Closed
DanTup opened this issue Apr 29, 2020 · 5 comments
Assignees
Labels
bug bugs found in the application debug issues that related to debug functionality vscode issues related to VSCode compatibility

Comments

@DanTup
Copy link
Contributor

DanTup commented Apr 29, 2020

I'm trying to track down an issue with debug sessions in the Dart VS Code extension not launching, and my suspicion is that it's due to us switching to using resolveDebugConfigurationWithSubstitutedVariables (see microsoft/vscode#87450).

VS Code now calls resolveDebugConfiguration as it previously did, then it resolves any variables (for example ${file}, ${workspaceFolder} etc.) and then calls resolveDebugConfigurationWithSubstitutedVariables. I think the code doing this is https://github.com/microsoft/vscode/blob/921b9a92a1b662fbe3aa21f47b0f8ed1fd89c947/src/vs/workbench/contrib/debug/browser/debugService.ts#L672-L685.

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Apr 29, 2020
@akosyakov
Copy link
Member

True, we don't support this API yet. Relevant PR in VS Code: microsoft/vscode@dba0076 PRs are welcomed.

@akosyakov akosyakov self-assigned this Jul 29, 2020
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Jul 29, 2020
akosyakov added a commit to tsmaeder/theia that referenced this issue Jul 29, 2020
…tutedVariables VS Code API

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@DanTup
Copy link
Contributor Author

DanTup commented Aug 3, 2020

@akosyakov is there an easy way to tell when a change is included in production GitPod? I'm going to build an updated Dart extension today, and I'm trying to figure out if I still need a workaround for this.

@akosyakov
Copy link
Member

@DanTup I'm planning to update Gitpod staging today. Do you have access to it? I can let you know. I don't know when it will make to production. cc @svenefftinge

@DanTup
Copy link
Contributor Author

DanTup commented Aug 3, 2020

Yep, I think I do still have access to staging. The question was mainly whether I needed the workaround for production though - if it's not already live, I'll include it (I'm building a specific copy of the extension to make my GitPod/Flutter web sample work again with the latest release of Dart-Code for those that want to try it out). Thanks!

minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
…tutedVariables VS Code API

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@DanTup
Copy link
Contributor Author

DanTup commented Oct 2, 2020

@akosyakov what's the status of this - were you waiting for me to test on staging? I tried on live today, but this doesn't seem to be working (resolveDebugConfiguration is called, but resolveDebugConfigurationWithSubstitutedVariables is not).

DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Oct 2, 2020
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Oct 7, 2020
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Dec 2, 2020
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Dec 16, 2020
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants