Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the scm commit input is gone #7734

Closed
akosyakov opened this issue May 4, 2020 · 4 comments · Fixed by #7769
Closed

the scm commit input is gone #7734

akosyakov opened this issue May 4, 2020 · 4 comments · Fixed by #7769
Labels
bug bugs found in the application critical critical bugs / problems scm issues related to the source control manager

Comments

@akosyakov
Copy link
Member

After working for a while, restarting the server and resetting the layout, the commit input is completely gone:
Screenshot 2020-05-04 at 15 05 04

Sorry, I don't have concrete steps :( but it did happen during testing and now happens in production.

cc @westbury
@akosyakov akosyakov added bug bugs found in the application scm issues related to the source control manager critical critical bugs / problems labels May 4, 2020
@akosyakov
Copy link
Member Author

One can recover only by cleaning origin caches and reloading afterwards. There seem to be some state layout mismanaged.

@westbury westbury added the 🤔 needs more info issues that require more info from the author label May 4, 2020
@westbury
Copy link
Contributor

westbury commented May 4, 2020

I have never seen this one. Is there anything in console output, or clues from dev tools?

We might also see if #7736 fixes this, as that does improve the storeState/restoreState.

@akosyakov
Copy link
Member Author

I can reproduce it by opening another folder on the disk which I've never opened before:
commig

I've tested against #7736

@westbury Can you have a look at it please? If not please let us know, that's quite critical to resolve.

@akosyakov akosyakov removed the 🤔 needs more info issues that require more info from the author label May 6, 2020
@westbury
Copy link
Contributor

westbury commented May 7, 2020

Thanks for the info. I can now reproduce it.

@westbury westbury mentioned this issue May 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application critical critical bugs / problems scm issues related to the source control manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing commit and amend widgets on opening new workspace eclipse-theia/theia
2 participants
@westbury @akosyakov