Fix missing commit and amend widgets on opening new workspace

[westbury]

Fixes #7734

The issue was caused because the commit and amend components were being rendered before the repository was set. Adding the repository listener in itself did not fix the problem. The reason is that the widget may be flagged as hidden when the update occurs.

One might think that updating the widgets by inserting this.commitWidget.update() after this.commitWidget.show() in scm-widget would work. However the 'show' is done asynchronously and the widget is still marked as hidden when the onUpdateRequest is called. Thus the most reliable solution is to simply remove the test for isVisible (and isAttached).

There is a further change to also remove this test in ScmWidget. If that is not done then the ScmNoRepositoryWidget can fail to appear, resulting in a blank view instead of the Alert.

Unrelated to the issue, I have also removed a couple of unused injections.

How to test

Test the condition detailed in the issue. Test around the whole process of switching repositories and workspaces. Check the Alert shows when no repository.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

I am off tomorrow. It would be good if someone review it.

[lmcbout]

Testing it right now on UBUNTU. If I put the focus on the SCM GIT view , opening a new view, closing + re-opening a view with / without GIT, after a few switch , the focus does not remain on the SCM GIT view. I need to re-select it to see the data.
The ALERT shows and the AMEND button also. Seems to work fine

[westbury]

If I put the focus on the SCM GIT view , opening a new view, closing + re-opening a view with / without GIT, after a few switch , the focus does not remain on the SCM GIT view. I need to re-select it to see the data.

If I understand correctly, if you open the Source Control view, then select, say, the explorer view, then close the explorer view, you expect the visible view to go back to the Source Control view but it sometimes shows the Debug view. I see this behavior on master and I don't think it is related to this PR.

[lmcbout]

Tested on UBUNTU 18.04
Switch workspaces, open a multi-root workspace with multiple git project, I was able to change the SCM for each GIT project, the "AMEND" button and "COMMIT" text field always present. Open + close workspace and the refresh always occurs.

[akosyakov]

Not sure whether it is related to the PR, but the input is styled differently now:

Before:

some padding is missing

Should I file another issue for it?

[akosyakov]

i cannot reproduce missing input anymore.

[akosyakov]

Filed #7794 for bogus input styling.