Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set minimal react version as 16.8 #7879

Closed
akosyakov opened this issue May 25, 2020 · 1 comment · Fixed by #7883
Closed

set minimal react version as 16.8 #7879

akosyakov opened this issue May 25, 2020 · 1 comment · Fixed by #7883
Labels
dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help preferences issues related to preferences

Comments

@akosyakov
Copy link
Member

akosyakov commented May 25, 2020 •
edited
Loading

React hooks were only introduced in https://reactjs.org/blog/2019/02/06/react-v16.8.0.html but we make use them with early version in package.json. We should bump it to make sure that downstreams update their yarn.lock files.
@akosyakov akosyakov added help wanted issues meant to be picked up, require help preferences issues related to preferences dependencies pull requests that update a dependency file labels May 25, 2020
@nisarhassan12
Copy link
Contributor

I would like to make a Pr for this.

nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 25, 2020
@nisarhassan12
bump react & react-dom to 16.8.
5eb6f5d 
Fixes eclipse-theia#7879
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 25, 2020
@nisarhassan12
bump react & react-dom to 16.8.
fb9028e 
Fixes eclipse-theia#7879
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 25, 2020
@nisarhassan12
bump react & react-dom to 16.8.
e20b5ee 
Fixes eclipse-theia#7879
@nisarhassan12 nisarhassan12 mentioned this issue May 25, 2020
Merged
1 task
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 25, 2020
@nisarhassan12
bump react & react-dom to 16.8.
9691bda 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 26, 2020
@nisarhassan12
bump react & react-dom to 16.8.
f40825d 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 26, 2020
@nisarhassan12
bump react & react-dom to 16.8.
ffffcb2 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 26, 2020
@nisarhassan12
bump react & react-dom to 16.8.
44000c6 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 26, 2020
@nisarhassan12
bump react & react-dom to 16.8.
53a2193 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 27, 2020
@nisarhassan12
bump react & react-dom to 16.8.
fca1097 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 27, 2020
@nisarhassan12
bump react & react-dom to 16.8.
649ac94 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
nisarhassan12 added a commit to nisarhassan12/theia that referenced this issue May 27, 2020
@nisarhassan12
bump react & react-dom to 16.8.
4ae69a8 
Fixes eclipse-theia#7879

Signed-off-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help preferences issues related to preferences
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump react & react-dom to 16.8 nisarhassan12/theia
2 participants
@akosyakov @nisarhassan12