Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser, Electron restore widgets differently on show #8078

Closed
colin-grant-work opened this issue Jun 23, 2020 · 4 comments
Closed

Browser, Electron restore widgets differently on show #8078

colin-grant-work opened this issue Jun 23, 2020 · 4 comments
Labels
bug bugs found in the application preferences issues related to preferences

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Jun 23, 2020

Bug Description:

A propos #8077, the behavior of the Preferences Widget, and perhaps React widgets more generally, is different in when Theia is run in the browser and when it is run in Electron. Here is an example of the scrollTop of the preferences-editor-widget during switch from that widget to another editor widget and back.

Here's the browser during a show-hide sequence:

browser-hide-show

And here's Electron with the same code:

electron-hide-show

Steps to Reproduce:

  1. Running in the browser,
  2. Open the preferences widget
  3. In the main pane, scroll down to an arbitrary point
  4. Open another editor widget and switch focus to that widget (at this point, do not enter Zen mode by double-clicking on a widget tab. If you do that, your scroll will be lost on both platforms)
  5. Switch focus back to the preferences widget.
  6. Observe that your scroll position was preserved
  7. Repeat in Electron, observe that your scroll position was lost.

preferences

Additional Information

  • Operating System: RHEL 7
  • Theia Version: 1.2.0
@vince-fugnitto
Copy link
Member

@colin-grant-work I opened the following issue but I'll keep yours opened since it has additional information: #8077 :)

@vince-fugnitto vince-fugnitto added bug bugs found in the application preferences issues related to preferences labels Jun 23, 2020
@colin-grant-work
Copy link
Contributor Author

@vince-fugnitto, yes, sorry it took me a while to open the issue!

@vince-fugnitto
Copy link
Member

@colin-grant-work I believe the issue has been fixed, I cannot reproduce it any longer.

@colin-grant-work
Copy link
Contributor Author

I can't reproduce it either. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

2 participants