Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theming of embedded editors in python notebook sometimes off #8374

Closed
akosyakov opened this issue Aug 13, 2020 · 1 comment · Fixed by #8381
Closed

theming of embedded editors in python notebook sometimes off #8374

akosyakov opened this issue Aug 13, 2020 · 1 comment · Fixed by #8381
Assignees
@akosyakov
Labels
bug bugs found in the application python issues related to the python language / extension theming issues related to theming vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@akosyakov
Copy link
Member

90132154-93db0680-dd6d-11ea-8345-15cad9560616

Content of editors and content assist proposals look coloured for the light theme
@akosyakov akosyakov added bug bugs found in the application python issues related to the python language / extension theming issues related to theming vscode issues related to VSCode compatibility webviews issues related to webviews labels Aug 13, 2020
@akosyakov akosyakov self-assigned this Aug 13, 2020
@akosyakov
Copy link
Member Author

It is caused by missing default values for workbench.colorTheme, something like #7174 should fix it.

@akosyakov akosyakov mentioned this issue Aug 14, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Aug 14, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
b92bd3a 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 14, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
df0d789 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 14, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
2b237c2 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 14, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
abfbc87 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 14, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
d12c8e5 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 17, 2020
@akosyakov
fix #8374: set default value of colorTheme and iconTheme preference
f58de79 
Also-by: tom-shan <swt0008411@163.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application python issues related to the python language / extension theming issues related to theming vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set default value of colorTheme and iconTheme preference eclipse-theia/theia
1 participant
@akosyakov