Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging Go application remotely not working when breakpoint is hit #8455

Closed
quoctruong opened this issue Sep 1, 2020 · 2 comments
Closed

Debugging Go application remotely not working when breakpoint is hit #8455

quoctruong opened this issue Sep 1, 2020 · 2 comments
Labels
debug issues that related to debug functionality go issues related to the go language help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@quoctruong
Copy link

Bug Description:

When debugging a Go application remotely, after the breakpoint is hit, I have no way to advance the breakpoint (see screenshot):
Screen Shot 2020-09-01 at 2 38 53 PM

Steps to Reproduce:

  1. Setup remote debugging for a Go program ((link)[https://github.com/golang/vscode-go/blob/master/docs/debugging.md#remote-debugging])
  2. Set a breakpoint
  3. Run the program until the breakpoint is hit.

Additional Information

  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility debug issues that related to debug functionality go issues related to the go language help wanted issues meant to be picked up, require help labels Sep 2, 2020
@quoctruong
Copy link
Author

quoctruong commented Sep 3, 2020 •
edited
Loading

Also I just notice that you can right clicked on the call stack to Continue (see image) even though you can't run F5 directly. Is this a bug in Theia?

image

@quoctruong quoctruong mentioned this issue Sep 15, 2020
Closed
gopherbot pushed a commit to golang/vscode-go that referenced this issue Sep 17, 2020
@quoctruong @hyangah
debugAdapter: fix a bug where we are not sending back configuration d…
29cee47 
…one response

This change is to address this bug: eclipse-theia/theia#8455. The Go extension is not able to continue past after hitting the breakpoint because `setConfigurationDoneRequest` is not sending back a response if the program is already running. This keeps Theia waiting for the response (which it never receives!).

Change-Id: Ie416638793d4c4505d9dd6b9e34753b60188ac5d
GitHub-Last-Rev: 5423aae
GitHub-Pull-Request: #641
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254959
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Quoc Truong <quoct@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit to golang/vscode-go that referenced this issue Sep 17, 2020
@quoctruong @hyangah
[release] debugAdapter: fix a bug where we are not sending back confi…
dfefea0 
…guration done response

This change is to address this bug: eclipse-theia/theia#8455. The Go extension is not able to continue past after hitting the breakpoint because `setConfigurationDoneRequest` is not sending back a response if the program is already running. This keeps Theia waiting for the response (which it never receives!).

Change-Id: Ie416638793d4c4505d9dd6b9e34753b60188ac5d
GitHub-Last-Rev: 5423aae
GitHub-Pull-Request: #641
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254959
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Quoc Truong <quoct@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
(cherry picked from commit 29cee47)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/255677
Reviewed-by: Quoc Truong <quoct@google.com>
@vince-fugnitto
Copy link
Member

@quoctruong does the issue still exist, or was it an issue with the vscode-go extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debug issues that related to debug functionality go issues related to the go language help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quoctruong @vince-fugnitto