Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails when downloading built-ins #9014

Closed
tsmaeder opened this issue Feb 1, 2021 · 16 comments · Fixed by #9017 or eclipse-che/che-theia#975
Closed

Build fails when downloading built-ins #9014

tsmaeder opened this issue Feb 1, 2021 · 16 comments · Fixed by #9017 or eclipse-che/che-theia#975
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions critical critical bugs / problems open-vsx issues related to the open-vsx registry

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 1, 2021 •
edited
Loading

Bug Description:

A build of master fails on the step where the built-ins are downloaded with these messages:

x vscode-builtin-configuration-editing: failed to download with: 404 Not Found
x vscode-builtin-emmet: failed to download with: 404 Not Found
x vscode-builtin-csharp: failed to download with: 404 Not Found
x vscode-builtin-go: failed to download with: 404 Not Found
x vscode-builtin-cpp: failed to download with: 404 Not Found
x vscode-builtin-handlebars: failed to download with: 404 Not Found
x vscode-builtin-grunt: failed to download with: 404 Not Found
x vscode-builtin-bat: failed to download with: 404 Not Found
x vscode-builtin-scss: failed to download with: 404 Not Found
x vscode-builtin-fsharp: failed to download with: 404 Not Found
x vscode-builtin-coffeescript: failed to download with: 404 Not Found
x vscode-builtin-pug: failed to download with: 404 Not Found
x vscode-builtin-objective-c: failed to download with: 404 Not Found
x vscode-builtin-debug-auto-launch: failed to download with: 404 Not Found
x vscode-builtin-clojure: failed to download with: 404 Not Found
x vscode-builtin-sql: failed to download with: 404 Not Found
x vscode-builtin-python: failed to download with: 404 Not Found
x vscode-builtin-shellscript: failed to download with: 404 Not Found
x vscode-builtin-ruby: failed to download with: 404 Not Found
x vscode-builtin-rust: failed to download with: 404 Not Found
x vscode-builtin-shaderlab: failed to download with: 404 Not Found
x vscode-builtin-theme-defaults: failed to download with: 404 Not Found
x vscode-builtin-theme-monokai-dimmed: failed to download with: 404 Not Found
x vscode-builtin-theme-abyss: failed to download with: 404 Not Found
x vscode-builtin-theme-tomorrow-night-blue: failed to download with: 404 Not Found
x vscode-builtin-typescript-language-features: failed to download with: 404 Not Found
x vscode-builtin-npm: failed to download with: 404 Not Found
x vscode-builtin-css: failed to download with: 404 Not Found
x vscode-builtin-theme-monokai: failed to download with: 404 Not Found
x vscode-builtin-theme-kimbie-dark: failed to download with: 404 Not Found
x vscode-builtin-theme-solarized-dark: failed to download with: 404 Not Found
x vscode-builtin-yaml: failed to download with: 404 Not Found
x vscode-builtin-theme-red: failed to download with: 404 Not Found
x vscode-builtin-typescript: failed to download with: 404 Not Found
x vscode-builtin-theme-quietlight: failed to download with: 404 Not Found
x vscode-builtin-vb: failed to download with: 404 Not Found
x vscode-builtin-xml: failed to download with: 404 Not Found
x vscode-builtin-icon-theme-seti: failed to download with: 404 Not Found
x vscode-builtin-swift: failed to download with: 404 Not Found
x vscode-builtin-docker: failed to download with: 404 Not Found
x vscode-builtin-lua: failed to download with: 404 Not Found
x vscode-builtin-r: failed to download with: 404 Not Found
x vscode-builtin-ini: failed to download with: 404 Not Found
x vscode-builtin-javascript: failed to download with: 404 Not Found
x vscode-builtin-less: failed to download with: 404 Not Found
x vscode-builtin-java: failed to download with: 404 Not Found
x vscode-builtin-make: failed to download with: 404 Not Found
x vscode-builtin-markdown: failed to download with: 404 Not Found
x vscode-builtin-merge-conflict: failed to download with: 404 Not Found
x vscode-builtin-powershell: failed to download with: 404 Not Found
x vscode-builtin-groovy: failed to download with: 404 Not Found
x vscode-builtin-hlsl: failed to download with: 404 Not Found
x vscode-builtin-log: failed to download with: 404 Not Found
x vscode-builtin-perl: failed to download with: 404 Not Found
x vscode-builtin-markdown-language-features: failed to download with: 404 Not Found
x vscode-builtin-jake: failed to download with: 404 Not Found
x vscode-builtin-gulp: failed to download with: 404 Not Found
x vscode-builtin-razor: failed to download with: 404 Not Found

I suspect some extension versions have been purged from open-vsx

Steps to Reproduce:

  1. git clone https://github.com/eclipse-theia/theia
  2. cd theia
  3. yarn
  4. Observe: error at the last build step

Additional Information

Using the browser to download a missing built-in extension (https://open-vsx.org/api/vscode/java/1.44.2/file/vscode.java-1.44.2.vsix) shows that the extension is indeed missing.

  • Operating System: Windows
  • Theia Version: master
@tsmaeder tsmaeder added bug bugs found in the application builtins Issues related to VS Code builtin extensions critical critical bugs / problems open-vsx issues related to the open-vsx registry labels Feb 1, 2021
@RomanNikitenko
Copy link
Contributor

+1
I see the same behavior

theia_errors

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Feb 1, 2021

The oldest version of the built-ins I find in open-vsx is 1 .45.1.

@kittaakos
Copy link
Contributor

kittaakos commented Feb 1, 2021 •
edited
Loading

I have noticed it as well. If I got it correctly from an internal chat, the Eclipse Publisher Agreement is mandatory for the extensions. All the extensions that were not signed, are not available anymore although they're still in the Azure blob.

For example, https://open-vsx.org/api/vscode/cpp/1.44.2/file/vscode.cpp-1.44.2.vsix was missing for me, but it's still under https://openvsxorg.blob.core.windows.net/resources/vscode/cpp/1.44.2/vscode.cpp-1.44.2.vsix

@spoenemann
Copy link
Contributor

@marcdumais-work could it be that version 1.44.2 was published to open-vsx.org with your own GitHub account? The grace period for signing the new Publisher Agreement has expired now, and all extension versions that are not backed by a signed Publisher Agreement have been disabled (they are no longer visible). If so, they can be reactivated by signing the agreement. Alternatively, we can delete those versions and republish them.

@marcdumais-work
Copy link
Contributor

Alternatively, we can delete those versions and republish them.

Let's try that. I'll setup, make sure this version still builds and report back

@marcdumais-work
Copy link
Contributor

v1.44.2 looks to still build ok.

@spoenemann How do we proceed? I think I can use vscode-builtin-extensions's CI to publish a new set of builtins of that version, if the old ones have been removed first. Do you figure ovsx will let this happen, with newer versions already existing?

@marcdumais-work marcdumais-work mentioned this issue Feb 1, 2021
Closed
@marcdumais-work
Copy link
Contributor

1.45.1 looks to be the earlier version what was published by the open-vsx bot user. A quick fix would be to update to that version, the built-ins that previously were version 1.44.2

seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
Update Built-in Extensions Version
8b7147b 
What it does

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
@seantan22 seantan22 mentioned this issue Feb 1, 2021
Merged
1 task
seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
Update Built-in Extensions Version (#7)
dbbe59a 
What it does

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
<!--
798c5d4 
Thank you for your Pull Request. Please provide a description and review
the requirements below.

Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md
-->

<!-- Include relevant issues and describe how they are addressed. -->

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

<!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. -->

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

- [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review)

- as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing)

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
Update Built-in Extensions Version
96ef0dd 
<!--
Thank you for your Pull Request. Please provide a description and review
the requirements below.

Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md
-->

<!-- Include relevant issues and describe how they are addressed. -->

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

<!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. -->

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

- [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review)

- as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing)

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
Update Built-in Extensions Version
99eec90 
<!--
Thank you for your Pull Request. Please provide a description and review
the requirements below.

Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md
-->

<!-- Include relevant issues and describe how they are addressed. -->

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

<!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. -->

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

- [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review)

- as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing)

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
@seantan22 seantan22 mentioned this issue Feb 1, 2021
Merged
1 task
seantan22 pushed a commit to seantan22/theia that referenced this issue Feb 1, 2021
Update Built-in Extensions Version
1841788 
What it does

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

How to test

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
@vzhukovs vzhukovs mentioned this issue Feb 1, 2021
Merged
9 tasks
marcdumais-work pushed a commit that referenced this issue Feb 1, 2021
@marcdumais-work
Update Built-in Extensions Version
3b5ebfd 
What it does

Fixes [#9014]

- Update necessary built-ins to version 1.45.1

How to test

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
@marcdumais-work
Copy link
Contributor

The immediate build problem for our example application was fixed by switching to a slightly newer version of the vscode-builtins.

To restore the v1.44.2 for others who may be using it, we can still re-publish v1.44.2 and are very close. I think we just need to remove the original extensions of that version from open-vsx.org and re-trigger the publish. See:
eclipse-theia/vscode-builtin-extensions#41 (comment)

@spoenemann WDYT?

@spoenemann
Copy link
Contributor

Yes I can remove those versions (and also all older versions?)

I would do that for all extensions in the vscode namespace. @marcdumais-work any objections?

The extensions can be listed here:
https://open-vsx.org/api/vscode

@marcdumais-work
Copy link
Contributor

@spoenemann yes, please proceed at your conveinence.

@marcdumais-work
Copy link
Contributor

and also all older versions?

Yes, I think so. I guess any that were published by me (under my GH user)

@spoenemann
Copy link
Contributor

I deleted 1.44.2 and older versions of all built-in extensions.

@benoitf benoitf mentioned this issue Feb 3, 2021
Merged
9 tasks
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Feb 3, 2021 •
edited
Loading

@spoenemann @marcdumais what should the policy be in the future with respect to old version of the built-ins in open-vsx?

@spoenemann
Copy link
Contributor

Generally we want to keep all old versions. We might consider deleting very old next versions at some point to reduce the cloud storage costs for the Eclipse Foundation.

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Feb 3, 2021 •
edited
Loading

I deleted 1.44.2 and older versions of all built-in extensions.

Thanks Miro. I will attempt to republish builtins 1.44.2 and markdown-language-features 1.39.2 that many were using and is a rare one known to work.
see

@mkuznyetsov mkuznyetsov mentioned this issue Feb 3, 2021
Closed
19 tasks
@tsmaeder tsmaeder mentioned this issue Feb 4, 2021
Closed
22 tasks
@marcdumais-work
Copy link
Contributor

I will attempt to republish builtins 1.44.2 and markdown-language-features 1.39.2 that many were using and is a rare one known to work.
see

This has been done

@magnologan magnologan mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application builtins Issues related to VS Code builtin extensions critical critical bugs / problems open-vsx issues related to the open-vsx registry
Projects
None yet
Milestone
No milestone
5 participants
@kittaakos @spoenemann @RomanNikitenko @tsmaeder @marcdumais-work