Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybindings: ctrl+k, ctrl+p does not work after rebinding 2 other shortcuts #9087

Closed
slhultgren opened this issue Feb 18, 2021 · 1 comment
Closed

keybindings: ctrl+k, ctrl+p does not work after rebinding 2 other shortcuts #9087

slhultgren opened this issue Feb 18, 2021 · 1 comment
Labels
keybindings issues related to keybindings

Comments

@slhultgren
Copy link
Contributor

Bug Description:

If a few shortcuts are rebinded, then ctrl+k ctrl+p (show all editors) stops working

Properties on the KeyCode object are not restored properly, so comparison of equals() will fail.
This leads to the key sequence being hanged on "ctrl+K", never accepting the complete sequence. This requires a restart of Theia to get back to normal shortcut behaviour.

Steps to Reproduce:

  1. Rebind "Format document" to "shift+alt+e"
  2. Rebind "editor: go to last edit location" to "ctrl+alt+left"
  3. Try using "ctrl+k, ctrl+p" to show all opened editors
  4. Observe that nothing happens and that the shortcut is stuck in "ctrl+k"
  5. Also observe crash of missing ".equals is not a function" in the developer tools console

Additional Information

  • Operating System: All
  • Theia Version: 1.10.0
slhultgren added a commit to slhultgren/theia that referenced this issue Feb 18, 2021
@slhultgren
Serialize the proper API object for the keymaps.json file
2dab357 
Fixes issue eclipse-theia#9087

Change-Id: I9c636c45654a028459247abc2d175c38bb9aaa58
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
slhultgren added a commit to slhultgren/theia that referenced this issue Feb 18, 2021
@slhultgren
Serialize the proper API object for the keymaps.json file
52b37b3 
Fixes issue eclipse-theia#9087

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>

Change-Id: I2ec63fe99797cf847a027be1a27eef2240970ee5
slhultgren added a commit to slhultgren/theia that referenced this issue Feb 18, 2021
@slhultgren
Serialize the proper API object for the keymaps.json file
732008d 
Fixes issue eclipse-theia#9087

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
slhultgren added a commit to slhultgren/theia that referenced this issue Feb 18, 2021
@slhultgren
Serialize the proper API object for the keymaps.json file
44cfe0f 
Fixes issue eclipse-theia#9087

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
@slhultgren slhultgren mentioned this issue Feb 18, 2021
Merged
1 task
@kenneth-marut-work kenneth-marut-work added the keybindings issues related to keybindings label Feb 19, 2021
kittaakos pushed a commit that referenced this issue Feb 24, 2021
@slhultgren @kittaakos
Serialize the proper API object for the keymaps.json file
d0265d6 
Fixes issue #9087

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
@vince-fugnitto
Copy link
Member

Closed thanks to #9088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vince-fugnitto @kenneth-marut-work @slhultgren