[siw] Typing into the files to include, exclude fields do not re-trigger the search

[kittaakos]

Bug Description:

The result in the SIW is not updated when changing the include/exclude fields. I have to press enter to rerun the search. It works from VS Code.

Steps to Reproduce:

Additional Information

• Operating System:
• Theia Version:

[AbhiSahane0]

Can I do this project Plz.

[vince-fugnitto]

Can I do this project Plz.

@AbhiSahane0 please go ahead 👍:

theia/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx

Lines 531 to 554 in b972e2b

	protected renderGlobField(kind: 'include' | 'exclude'): React.ReactNode {
	const currentValue = this.searchInWorkspaceOptions[kind];
	const value = currentValue && currentValue.join(', ') || '';
	return <div className='glob-field'>
	<div className='label'>{'files to ' + kind}</div>
	<input
	className='theia-input'
	type='text'
	size={1}
	defaultValue={value}
	id={kind + '-glob-field'}
	onKeyUp={e => {
	if (e.target) {
	if (Key.ENTER.keyCode === e.keyCode) {
	this.resultTreeWidget.search(this.searchTerm, this.searchInWorkspaceOptions);
	} else {
	this.searchInWorkspaceOptions[kind] = this.splitOnComma((e.target as HTMLInputElement).value);
	}
	}
	}}
	onFocus={kind === 'include' ? this.handleFocusIncludesInputBox : this.handleFocusExcludesInputBox}
	onBlur={kind === 'include' ? this.handleBlurIncludesInputBox : this.handleBlurExcludesInputBox}></input>
	</div>;
	}

theia/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx

Line 542 in b972e2b

onKeyUp={e => {

[AbhiSahane0]

sir what to do with 'onKeyUp={e => { '

[vince-fugnitto]

sir what to do with 'onKeyUp={e => { '

@AbhiSahane0 you'll likely need to modify this handler when creating the glob fields (include and exclude) so that they search on input rather than wait for an Enter key to be pressed (similarly to the actual search input). The logic to split the input (on commas) should be preserved to support globs.

[AbhiSahane0]

So, should I remove the if else part so that user directly go for input

[vince-fugnitto]

So, should I remove the if else part so that user directly go for input

@AbhiSahane0 I believe there is enough information in the issue (including comments) in order to get started on a fix.
I think the best way forward would be to attempt the fix yourself including testing different scenarios and when you provide a pull-request we can guide you through any improvements if necessary.

Remember that we now want to trigger searching when users type into the inputs (similarly to the search) but want to preserve logic that does the comma split to support passing multiple glob patterns (which is already present but needs to be slightly modified).

[kittaakos]

Thank you so much for your assistance, @AbhiSahane0. I really needed the fix, so here is the PR: #9183

Please chime-in and propose any changes if you do not like my approach. Thanks!