Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocationLink and Declaration #10139

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add LocationLink and Declaration #10139

merged 1 commit into from
Oct 12, 2021

Conversation

smart-bo
Copy link
Contributor

What it does

fix: #10024
Add LocationLink and Declaration to theia.d.ts

How to test

Review checklist

Reminder for reviewers

msujew
msujew reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smart-bo, thanks again for your contribution.

I think you might have added ceaeee0 to this PR by accident :)

packages/plugin/src/theia.d.ts Outdated Show resolved Hide resolved
@msujew msujew added the vscode issues related to VSCode compatibility label Sep 21, 2021
msujew
msujew approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! The definition of LocationLink and DefinitionLink is reversed compared to vscode, but they are semantically identical and the JSDoc is still correct, so I don't see a lot of reason to change that 👍

@msujew msujew merged commit 5f811c8 into eclipse-theia:master Oct 12, 2021
@vince-fugnitto vince-fugnitto added this to the 1.19.0 milestone Oct 28, 2021
@planger planger mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

Align LocationLink, Definition and Declaration with VS Code
3 participants
@smart-bo @msujew @vince-fugnitto