add ts-clean script #10156
Merged
add ts-clean script #10156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
quality
paul-marechal
force-pushed
the
mp/smart-clean
branch
from
522053c to
94e3947
Compare
|
@vince-fugnitto CI is fixed \o/ |
msujew
approved these changes
Sep 24, 2021
When doing refactorings, one might end up renaming/deleting TypeScript source files. But if a build was run previously, the outputted JavaScript files will still be in the build output folder. Then extensions that depend on the refactored package will not fail to build because the old path still resolves to the lingering JavaScript files. Add `ts-clean` script that deletes all generated files without a corresponding source file. Add the missing `compile` script to most packages.
paul-marechal
force-pushed
the
mp/smart-clean
branch
from
e678af8 to
1de2cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing refactorings, one might end up renaming/deleting TypeScript
source files. But if a build was run previously, the outputted
JavaScript files will still be in the build output folder. Then
extensions that depend on the refactored package will not fail to build
because the old path still resolves to the lingering JavaScript files.
Add
ts-cleanscript that deletes all generated files without acorresponding source file.
Add the missing
compilescript to most packages.How to test
npx ts-clean dev-packages/* packages/* --dry.The tool supports a
--watch (-w)mode, use--dryto only get logs without touching the fs.Review checklist
Reminder for reviewers