-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Performance Tests in CI #10463
Integrate Performance Tests in CI #10463
Conversation
66ec2d1
to
850c411
Compare
850c411
to
fdb7959
Compare
fdb7959
to
29a5ef7
Compare
Commit 29a5ef7 rebases the branch onto recent changes on |
29a5ef7
to
49d01f7
Compare
Bumping, much needed feature to be able to improve the startup performance, this is the first milestone to start to be able to track the duration to see what can be improved. |
49d01f7
to
4cc485d
Compare
Commit b41f101 rebases the original commit again following the release tag of 1.32.0 in the changelog, adding a new 1.33.0 section and putting the change entry there. Commit 4cc485d then factors out the performance-test workflow into its own file with, for now, only the dispatch trigger. I've also made a few other updates to align with changes in the dependencies used by other builds (Node version, Ubuntu version, action versions) in the months since the original contribution. |
I don't recognize the test failures on Ubuntu as anything that I could have broken with this PR. Not sure what to do about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good to me 👍
I'm fine with keeping it as a manual workflow dispatch for the time being.
This time, one of the Linux test platforms that failed previously passed and one of the Mac test platforms that passed previously failed. Definitely seems unrelated to the changes in this PR. |
- update performance scripts to report results for history and regression test - configure the build workflow for performance tests - track performance history - use benchmark action to check for regression - publish results to GH Pages - only use the dispatch trigger, for now Contributed on behalf of STMicroelectronics. Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
c785524
to
6531598
Compare
Commit 6531598 resolves the usual changelog conflict. And so I took the opportunity while to doing that to squash the branch. No other changes. |
What it does
Adds a “Performance Tests” job to the build workflow in the project’s GitHub Actions to execute the browser and Electron start-up performance scripts, record and chart the results, and compare with past results for regression. The job is configured to
Example output: an example of the performance history chart produced by these changes is available here.
A new dependency on the third-party github-action-benchmark GitHub action is added. It is configured to
/docs/next/
content already published on this branch. This can be seen hereHEAD
commit with comments when performance regression is detectedResolves #10443.
Contributed on behalf of STMicroelectronics.
How to test
Execute the performance scripts pretending the GitHub CI environment:
This will record performance measurements to the
performance-result.json
file that the GitHub benchmark action picks up for its history recording and analysis.As the build job is configured not to run on PR branches but only on the master branch, testing the rest of the flow is more tricky. The behaviour can be observed in this fork in which the changes were initially drafted.
Review checklist
Reminder for reviewers