Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running plugin host on electron windows #10518

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

Tom-Yucw
Copy link
Contributor

@Tom-Yucw Tom-Yucw commented Dec 8, 2021

What it does

Closes #6846

to run plugins created by yo @theia/plugin on windows.

How to test

  1. Using yo @theia/plugin to make a Hello World plug-in
  2. Adding nodejs version like "@types/node": "12.20.0" in package.json to avoid error "node_modules@types\node\assert.d.ts"
  3. Run yarn to build plugin
  4. Run "Hosted Plug-in: Start Instance" in command, and select the source directory which includes file package.json

A new instance is showed up successfully on windows.

Review checklist

Reminder for reviewers

@msujew msujew added the electron issues related to the electron target label Dec 8, 2021
@msujew msujew changed the title run plugins created by yo @theia/plugin on windows: https://github.co… Fix running plugin host on electron windows Dec 8, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I can confirm that the issue exists on master and is addressed by the changes nicely 👍

@Tom-Yucw Tom-Yucw closed this Dec 8, 2021
@msujew
Copy link
Member

msujew commented Dec 8, 2021

@Tom-Yucw Please don't create a new PR for every change, and simply add your changes to this PR. If you choose to amend to your first commit, you can force push them using git push -f.

@vince-fugnitto
Copy link
Member

@msujew should we merge for this week's release?

@msujew msujew merged commit 858bda8 into eclipse-theia:master Dec 14, 2021
@vince-fugnitto vince-fugnitto added this to the 1.21.0 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-hosting does not work on Windows in Electron mode
3 participants