-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn upgrade + dep fix #10725
yarn upgrade + dep fix #10725
Conversation
d4b1e4a
to
1d925e6
Compare
3301674
to
7a33f39
Compare
The commit includes the following updates: - performs a `yarn upgrade` and consequently resolves dependency issues such as `simple-get` pulled transitively by `drivelist`. -sets `@electron/remote` range to avoid version `2.0.4` as the typings are bogus.
7a33f39
to
5afb757
Compare
The dependencies are now approved 👍 |
In smoke tests of both browser and Electron applications, everything seemed to be working fine. During the Electron rebuild portion of the build, I did see some compiler warnings that I'm not used to seeing, but the build succeeded and everything looked fine, so I'm not sure whether the output reflects change in dependencies or change in warning behavior of my local native build chain.
Since we recently updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the new warnings from electron-rebuild
, which seem to be unrelated to this PR, this looks good to me.
What it does
The pull-request includes the following changes:
yarn upgrade
on the repo, consequently resolving known security vulnerabilities from dependencies.@electron/remote
range to avoid version2.0.4
as the typings are bogus (fixed upstream but not yet in a patch release).How to test
simple-get
vulnerability exists (ex: yarn audit | grep "simple-get")Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com