Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure default icon theme is properly applied even if registered late #10938

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Ensure default icon theme is properly applied even if registered late #10938

merged 1 commit into from
Mar 29, 2022

Conversation

martin-fleck-at
Copy link
Contributor

What it does

Ensures that the default icon theme is applied properly even if registered late by storing it in the local cache on initialization.

Fixes #10937

How to test

  1. Setup available on this branch as well: https://github.com/martin-fleck-at/theia/tree/issue-10937-case
  2. Install any icon theme from vsx into your product, e.g., https://open-vsx.org/extension/PKief/material-icon-theme
  3. Set the default icon theme for your application to that theme, e.g., "defaultIconTheme": "material-icon-theme"
  4. Start up the (browser or electron) application and see if the theme is applied on a clean state. You can get to a clean state by clearing the browser data or removing the respective electron directories.
file-icon-theme-application-fix.mp4

Review checklist

Reminder for reviewers

@msujew msujew self-requested a review March 28, 2022 15:24
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking quite good to me 👍

  • Setting the default file icon theme to material-icon-theme (after installing the extension) loads the icons as expected after a short initialization phase.
  • Doing the same without installing the extension loads the default theme.
  • Removing the extension again displays the default theme.

@vince-fugnitto vince-fugnitto added the theming issues related to theming label Mar 28, 2022
@msujew msujew merged commit f044a0a into eclipse-theia:master Mar 29, 2022
@xcariba xcariba mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming issues related to theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default icon themes from plugins are not properly applied the first time
3 participants