Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/rename messaging contribution push param #10996

Closed
wants to merge 5 commits into from
Closed

Refactor/rename messaging contribution push param #10996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f8d270
refactor: rename MessagingContribution.push param
alijs Apr 6, 2022
b66fb6c
refactor: add changelog
alijs Apr 6, 2022
4cd16d0
refactor: add changelog
alijs Apr 6, 2022
654a7f9
refactor: add changelog
alijs Apr 6, 2022
5d7b877
refactor: add type declaration in ConnectionHandlers.push method
alijs Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- [core] Move code for untitled resources into `core` from `plugin-ext` and allow users to open untitled editors with `New File` command. [#10868](https://github.com/eclipse-theia/theia/pull/10868)
- [plugin] added support for `SnippetString.appendChoice` [#10969](https://github.com/eclipse-theia/theia/pull/10969) - Contributed on behalf of STMicroelectronics
- [core] rename ConnectionHandlers.push param in packages/core/src/node/messaging/messaging-contribution.ts [#10996](https://github.com/eclipse-theia/theia/pull/10996)

<a name="breaking_changes_1.25.0">[Breaking Changes:](#breaking_changes_1.25.0)</a>

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/node/messaging/messaging-contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export namespace MessagingContribution {

push(spec: string, callback: (params: MessagingService.PathParams, connection: T) => void): void {
const route = new Route(spec);
this.handlers.push((path, channel) => {
this.handlers.push((path, channel: T) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value in this change?

We can already infer the type from handlers:

protected readonly handlers: ((path: string, connection: T) => string | false)[] = [];

and the editor gives us hover information that channel is of type T.

What exactly is the change attempting to achieve?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, please ignore this pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! If there are improvements or features you'd like to work on please don't hesitate to contribute and we'd be happy to review them :)

const params = route.match(path);
if (!params) {
return false;
Expand Down