Revert #11011 #11204
Merged
Revert #11011 #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
requested review from
JonasHelming,
tsmaeder,
paul-marechal and
vince-fugnitto
colin-grant-work
force-pushed
the
revert/11011
branch
from
63faec5 to
3fd2ef9
Compare
|
I cannot enter code review at the moment, but I +1 this |
|
and thank you @colin-grant-work for taking care of this! |
colin-grant-work
force-pushed
the
revert/11011
branch
from
3fd2ef9 to
be1cf9b
Compare
|
After a false start, this should be a full reversion of #11011, if CI gives the all clear. |
vince-fugnitto
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR reverts #11011 after several issues were discovered with it after merge.
Issues: #11203 (critical), #11199
How to test
Review checklist
Reminder for reviewers