Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix node version when publishing #11269

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Following #11210, we need to update the node version we use when publishing, else we will get an error as the check does not pass:

Run yarn --skip-integrity-check --network-timeout 100000
yarn install v1.22.18
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using node-gyp@5.1.0
gyp info using node@[12](https://github.com/eclipse-theia/theia/runs/6777317063?check_suite_focus=true#step:5:13).22.12 | linux | x64
gyp http GET https://nodejs.org/download/release/v12.22.12/node-v12.22.12-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v12.22.12/node-v12.22.12-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v12.22.12/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v12.22.12/SHASUMS256.txt
12.22.12
gyp info ok 
[1/5] Validating package.json...
error @theia/monorepo@0.0.0: The engine "node" is incompatible with this module. Expected version ">=[14](https://github.com/eclipse-theia/theia/runs/6777317063?check_suite_focus=true#step:5:15)". Got "12.[22](https://github.com/eclipse-theia/theia/runs/6777317063?check_suite_focus=true#step:5:23).12"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1.

How to test

N/A.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The drop of node 12 means we also need to update the version of node we
use when we publish as 12 would cause the check to fail.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Jun 7, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paul-marechal paul-marechal merged commit b2e44a9 into master Jun 7, 2022
@paul-marechal paul-marechal deleted the vf/fix-publishing branch June 7, 2022 18:03
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 7, 2022
@paul-marechal
Copy link
Member

paul-marechal commented Jun 7, 2022

At least we're sure that the engine check works now :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants