Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: fix license:check baseline #11295

Merged
merged 1 commit into from
Jun 15, 2022
Merged

repo: fix license:check baseline #11295

merged 1 commit into from
Jun 15, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Currently, our github homepage for the repo is reporting an unknown license.
It seems like the license-check-baseline.json is being interpreted as a license file and confusing github according to their docs.

If your repository is using a license that is listed on the Choose a License website and it's not displaying clearly at the top of the repository page, it may contain multiple licenses or other complexity. To have your license detected, simplify your LICENSE file and note the complexity somewhere else, such as your repository's README file.

Screen Shot 2022-06-14 at 3 17 29 PM

How to test

  1. confirm that CI is passing.
  2. confirm that the yarn license:check command works well.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit updates the `license:check` baseline so it does not report a false `license` on github.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the repo issues specific to the repository label Jun 14, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@vince-fugnitto vince-fugnitto merged commit bf905e8 into master Jun 15, 2022
@vince-fugnitto vince-fugnitto deleted the vf/license-check branch June 15, 2022 13:57
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo issues specific to the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants