feat(scm): add visibility variable in plugin API

[xai]

What it does

Adds support to specify whether a SourceControlInputBox is visible

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich olessenich@eclipsesource.com

Fixes #11140
Closes #11348

How to test

0. Remove the @theia/git extension from your build to correctly test this.
1. Install the test extension vscode-extension-sourcecontrol-inputbox-11140-0.0.1.zip in your theia workspace from your local filesystem.
2. Use the command SourceControlInputBox: Status which is provided by the extension to display the properties of sourceControl.inputBox. Verify that a Boolean visible property is present.
3. (Optional: Use the provided commands SourceControlInputBox: Hide and SourceControlInputBox: Show to manipulate the respective Boolean. Verify the change with SourceControlInputBox: Status.)
4. This extension can be installed in VSCode as well to compare the behaviour.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

I've modified your PR message (added a test step 0 and that it closes another PR), I hope that's fine with you.

I've also noticed that the changes in the PR don't lead to the actual input box being made visible/invisible:

2022-07-12.11-28-14.mp4

I believe there might be some code missing at this place:

theia/packages/scm/src/browser/scm-commit-widget.tsx

Lines 134 to 145 in 9d4ab29

	<TextareaAutosize
	className={`${ScmCommitWidget.Styles.INPUT_MESSAGE} theia-input theia-scm-input-message-${validationStatus}`}
	id={ScmCommitWidget.Styles.INPUT_MESSAGE}
	placeholder={message}
	spellCheck={false}
	autoFocus={true}
	value={input.value}
	onChange={this.setInputValue}
	ref={this.inputRef}
	rows={1}
	maxRows={6} /* from VS Code */>
	</TextareaAutosize>

[xai]

I've modified your PR message (added a test step 0 and that it closes another PR), I hope that's fine with you.

Thanks!

I've also noticed that the changes in the PR don't lead to the actual input box being made visible/invisible

I'll look into this - thanks for the pointer!

[xai]

I added a change so that the TextareaAutosize element is only included when it is supposed to be visible. SourceControlInputBox: Hide and SourceControlInputBox: Show from the test extension do now have an effect on whether the inputBox is displayed or not.

[colin-grant-work]

With the recent changes, the intended functionality appears to be in place. Some minor comments on the React side of things.

[msujew]

Thanks, the changes look good to me. I can confirm that the SourceControlInputBox#visible property behaves as in vscode 👍