Add missing vscode api in env namespace #11446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added appHost, isNewAppInstall, isTelemetryEnabled, onDidChangeTelemetryEnabled, and remoteName API to our missing vscode API implementation. For isNewAppInstall, we use the creation date of a random theia file as installation date. Moreover, since theia doesn't support telemetry, we implemented stubs for the API related to telemetry.
msujew
reviewed
Jul 20, 2022
There was a problem hiding this comment.
@yiningwang11 Thank you for your first contribution!
Please make sure to sign the ECA with the same email as your commit in order for us to accept your changes.
packages/plugin-ext/src/hosted/browser/worker/worker-env-ext.ts
Outdated
Show resolved
Hide resolved
…se to keep compatibility with vscode.
|
@yiningwang11 Is this ready for a re-review? I see that the ECA succeeds now. |
vince-fugnitto
approved these changes
Jul 28, 2022
JonasHelming
approved these changes
Jul 28, 2022
|
@vince-fugnitto : Can we merge this for the release still? |
|
@JonasHelming the changes were low risk enough to be merged in our opinion, yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10662
The pull-request adds support for the
envnamespace according to the vscode API:appHostisNewAppInstallisTelemetryEnabledonDidChangeTelemetryEnabledremoveNameHow to test
Using the electron app, notifications indicating the value of those APIs would pop up.The appHost is set to 'desktop', the remoteName is set to 'undefined'. For isNewAppInstall, we use the creation date of a random theia file as the installation date. Moreover, since theia doesn't support telemetry, we implemented stubs for the API related to telemetry. The isTelemetryEnabled API is set to false. The onDidChangeTelemetryEnabled always fires an empty event.
Review checklist
Reminder for reviewers