Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some localization #11629

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix some localization #11629

merged 1 commit into from
Sep 27, 2022

Conversation

yiliang114
Copy link
Contributor

What it does

fix some localization

How to test

  1. Start App and Switch 中文(简体) zh-cn language
  2. Click Extension activity bar and search some extensions what ever.
  3. Hover your cursor and check out it's tooltips.
  4. Check out the translation of the copy extension Id.

Review checklist

Reminder for reviewers

before:
image

after:
image

@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Sep 2, 2022
colin-grant-work
colin-grant-work reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks as always!

colin-grant-work
colin-grant-work approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last comment was meant to be an approval, and this is actually an approval.

@colin-grant-work colin-grant-work merged commit 22a5f7e into eclipse-theia:master Sep 27, 2022
@colin-grant-work colin-grant-work added this to the 1.30.0 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yiliang114 @colin-grant-work @vince-fugnitto