monaco: uplift to 1.72.3

[vince-fugnitto]

What it does

The pull-request uplifts monaco to 1.72.2 (latest vscode tag).

How to test

Checklist:

• confirm that syntax highlighting works for multiple languages
• confirm that the outline-view is properly populated
• confirm that problem markers work properly
• confirm that language-features work properly (go to definition, call hierarchy, peek >, refactor)
• confirm that quick fixes work
• confirm that the quick input and quick open menu works
• confirm that editor styling works
• confirm that the new preferences work (ex: editor.stickyScroll.enabled)
• confirm other editor or monaco related features work

Additional Information

• CQ for @theia/monaco-editor-core@1.72.2
• CQ for @theia/monaco-editor-core@1.72.3

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[planger]

@vince-fugnitto I saw that this PR breaks the playwright tests. Please feel free to ping me anytime if we can help out adapting the page object library to make the tests work again.

[vince-fugnitto]

@vince-fugnitto I saw that this PR breaks the playwright tests. Please feel free to ping me anytime if we can help out adapting the page object library to make the tests work again.

@planger thanks! You can take a look at them if you'd like, I was having a hard time actually debugging playwright.

[planger]

@vince-fugnitto Thanks, we'll take a look! As many of us are currently on EclipseCon, I'm not sure we'll get to it this week though. To avoid blocking your PR, feel free to disable the failing test temporarily, and we'll open a PR at latest next week to fix and re-enable it.

Thanks!

[planger]

@vince-fugnitto I've had a look at the failing test. It seems like Monaco now adds a "zero width non-joiner" character (‌ or \u200c) to the HTML text content. So the most direct way to resolve this is to replace the method replaceEditorSymbolsWithSpace(content: string) in examples/playwright/src/theia-text-editor.ts with the one below:

    protected replaceEditorSymbolsWithSpace(content: string): string | Promise<string | undefined> {
        // [ ] &nbsp; => \u00a0 -- NO-BREAK SPACE
        // [·] &middot; => \u00b7 -- MIDDLE DOT
        // [] &zwnj; => \u200c -- ZERO WIDTH NON-JOINER
        return content.replace(/[\u00a0\u00b7]/g, ' ').replace(/[\u200c]/g, '');
    }

[msujew]

The changes look good to me. I've tried testing the monaco features and the added preferences in particular. Everything seems to work as expected 👍

I would propose to merge this PR rather sooner than later to catch potential issues before the next release.

[vince-fugnitto]

I would propose to merge this PR rather sooner than later to catch potential issues before the next release.

Thank you for the review!

I performed an official release of @theia/monaco-editor-core@1.72.3 and filed a CQ for it with the modifications to license and third-party-notices the foundation asked for.

[vince-fugnitto]

The latest CQ has been approved 👍

[vince-fugnitto]

As mentioned in the dev meeting, I'll merge the pull-request tomorrow and we have the rest of the month to identify any potential regressions.

[vince-fugnitto]

The test seems to fail due to quickInputList.ts#getAriaLabel, where the recently used seperator is added to the aria-label.