Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some webpack warnings #11835

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fix some webpack warnings #11835

merged 1 commit into from
Nov 7, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 4, 2022

What it does

Related to #11432

This change fixes/circumvents 3 kinds of webpack warnings:

  1. Missing source maps. We ignore those, as these come from dependencies and it doesn't really harm us too much
  2. Weird require usage in monaco on a path which is never executed. We can ignore that as well
  3. Unable to inline url('') css. I've replaced the URL with a gradient which serves the same result

How to test

Only the third point can actually be tested. It's a regression test against #7751. The plugin icons should be empty instead of a grey box.

For everything else: The related webpack warnings shouldn't appear anymore when running theia build.

Review checklist

Reminder for reviewers

@msujew msujew added the quality issues related to code and application quality label Nov 4, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

  • confirmed that source map warnings are no longer present
  • custom icons from plugins do not display the grey square on reload

@msujew msujew merged commit 3e25fc4 into master Nov 7, 2022
@msujew msujew deleted the msujew/ignore-webpack-warnings branch November 7, 2022 13:29
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants