Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for TaskGroup.id and TaskGroup.isDefault #11944

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Dec 2, 2022

What it does

Adds support for id and isDefault and includes a small drive-by fix in the Task implementation where the taskRunOptions object was not properly initialized.

Fixes #11519

Contributed on behalf of ST Microelectronics

How to test

  1. Install the attached vscode extension. It is built from https://github.com/tsmaeder/castletest
  2. Open a workspace that generates some tasks. I use the source of Theia
  3. Configure some tasks, playing with the "id" and "default" fields
  4. Inspect the task by invoking "Dump task info to console" from the command palette and make sure the right values are shown for "isDefault" and "id".

Review checklist

Reminder for reviewers

Adds support for id and isDefault and includes a small drive-by fix in
the Task implementation where the taskRunOptions object was not properly
initialized.

Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 2, 2022

castletest-0.0.1.zip

@vince-fugnitto vince-fugnitto added tasks issues related to the task system vscode issues related to VSCode compatibility labels Dec 2, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I confirmed the changes work as expected:

  • confirmed that the compatibility report is now marked as supported for TaskGroup.id and TaskGroup.isDefault
  • there is completion help when editing tasks to set the group (including isDefault)
  • running the default "build task" works as expected
  • running the default "test task" works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] TaskGroup misses support for id and isDefault
2 participants