Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace xvfb action #11945

Merged
merged 1 commit into from
Dec 5, 2022
Merged

ci: replace xvfb action #11945

merged 1 commit into from
Dec 5, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Dec 2, 2022

What it does

The pull-request updates our gh workflow to remove the deprecated GabrielBB/xvfb-action@v1 in favor of the default xvfb provided by the ubuntu-latest runner. The previous action did not seem to be actively maintained, and was using Node 12 which GitHub marked as deprecated.

The following annotations should be fixed as a result:

image

How to test

  • Confirm that CI passes
  • Confirm that there are no annotations on the summary page regarding deprecated actions (ex: summary)

Review checklist

Reminder for reviewers

The commit replaces the deprecated (due to inactivity) action for `xvfb`
in favor of using the one provided by default from the latest `ubuntu` runner.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Dec 2, 2022
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the annotations are gone and CI passes - thanks Vince!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants