Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11509
Closes #199
This was more work than initially expected. It seems like we didn't handle readonly editors at all previously (see #199). So this change not only adds the file system permissions extension API, but also enables us to pass permission information all the way to the monaco model and phosphor tabbars.
How to test
Open file from file system
commands. They should all result in read only editors except for the one that opens themutable-in-mutable
file.Check file system isWritableFileSystem
command. Input different URI schemes which then displays a notification containing the result of theisWritableFileSystem
call. The extension contributes thereadonly
andmutable
file system schemes, which should returnfalse
/true
respectively. Calls tofile
should also returntrue
. Everything else should returnundefined
, unless contributed by an extension or plugin.Review checklist
Reminder for reviewers