Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: fix notebook stubs #12003

Merged
merged 1 commit into from
Dec 19, 2022
Merged

plugin: fix notebook stubs #12003

merged 1 commit into from
Dec 19, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #11993 (comment).

The pull-request fixes some stubs from the notebook API which prevented extensions from activating and producing errors.

How to test

  1. include the following test extension (vscode-github-issue-notebooks-0.0.130.zip)
  2. start the application
  3. execute the command "New GitHub Issue Notebook"
  4. confirm that the extension activates and does not produce an error notification
  5. confirm on master that the same steps will produce an error

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto
plugin: fix notebook stubs
5353de7 
The commit fixes some stubs from the `notebook` API which prevented
extensions from activating and producing errors.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility notebook issues related to notebooks labels Dec 16, 2022
@JonasHelming
Copy link
Contributor

@rschnekenbu : Could you have a look?

rschnekenbu
rschnekenbu approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I indeed get same issues during activation on master, and no errors are shown when running with this change.

@vince-fugnitto vince-fugnitto merged commit 885d50e into master Dec 19, 2022
@vince-fugnitto vince-fugnitto deleted the vf/notebook-stub branch December 19, 2022 13:58
@github-actions github-actions bot added this to the 1.33.0 milestone Dec 19, 2022
This was referenced Feb 13, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschnekenbu rschnekenbu rschnekenbu approved these changes

@JonasHelming JonasHelming JonasHelming approved these changes

Assignees
No one assigned
Labels
notebook issues related to notebooks vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vince-fugnitto @JonasHelming @rschnekenbu