Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the pseudo-terminal open event is not triggered #12005

Closed
wants to merge 1 commit into from

Conversation

zvzuola
Copy link

@zvzuola zvzuola commented Dec 18, 2022

What it does

Fix the problem that the pseudo-terminal open event of the custom task is not triggered

How to test

  1. install the following test extension task-provider-samples-0.0.1.vsix.zip (build form task-provider-sample)
  2. Open any workspace and create a Rakefile empty file
  3. Run task, and select "custombuildscript: 32 incremental" task to run
  4. The pseudo-terminal open event is not triggered and the task is not running

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility terminal issues related to the terminal labels Jan 10, 2023
@vince-fugnitto
Copy link
Member

@zvzuola are you still interested in contributing the fix?

@thegecko
Copy link
Member

This issue is outlined in #11858 and as mentioned there, the fix may be to just revert #10780.

@arekzaluski I thought this had been resolved by you?

@thegecko
Copy link
Member

Thanks @zvzuola, this should be fixed by reverting #10780 which I've done in #12098.

Closing this as superseded by the new PR.

@thegecko thegecko closed this Jan 23, 2023
@thegecko thegecko mentioned this pull request Feb 3, 2023
1 task
@zvzuola zvzuola deleted the fix/custom_task branch July 5, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants