Added localization for debug level selector #12033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Jan 9, 2023
packages/core/src/common/severity.ts
Outdated
Comment on lines
34
to
38
| const error = nls.localize('theia/core/severity/errors', 'Errors'); | ||
| const warning = nls.localize('theia/core/severity/warnings', 'Warnings'); | ||
| const info = nls.localize('theia/core/severity/info', 'Info'); | ||
| const log = nls.localize('theia/core/severity/log', 'Log'); | ||
| const ignore = nls.localize('theia/core/severity/all', 'All'); |
There was a problem hiding this comment.
Suggestion: I'm not too sure whether we should localize these values directly. I would rather have a Severity.toLocaleString() function that accepts a string | Severity and returns a localized version of the string. Use the result at the caller site of debug-console-contribution.tsx.
vince-fugnitto
added
debug
|
@xcariba Are you still interested in contributing this change? |
Signed-off-by: Alexander Kozinko <xcariba@gmail.com>
xcariba
force-pushed
the
fix-debug-levels-localization
branch
from
503dd14
to
05ce583
Compare
|
@msujew Yes, I just don't have enough time =( I agree with your suggestion, fixed PR |
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11973.
Adds localization support for debug console severity.
How to test
console.error('My Error'); console.info('My Info');debugger;call or set breakpointReview checklist
Reminder for reviewers