Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added localization to "preparing download" Message; #12041

Merged

Conversation

jonah-iden
Copy link
Contributor

Also added translations for newly localized values for german and english

Signed-off-by: Jonah Iden jonah.iden@typefox.io

What it does

This fixes issue #11988
adds localization to the in the picture marked texts. Also added german translation for these.
grafik

How to test

(copied from issue)

  1. start the browser application (the download command is not available on electron) with theia as a workpace
    
  2. execute F1 > Configure Display Language, install a new language-pack, and restart the application
    
  3. open the explorer
    
  4. attempt to download a big resource (ex: node_modules) by right-clicking the directory and choosing the "download" command (will be localized)
    
  5. confirm that the progress notification is not localized
    

Review checklist

Reminder for reviewers

Also added translations for newly localized values
for german and english

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the default values from the nls.json file. Looks good to me otherwise 👍

packages/core/i18n/nls.json Outdated Show resolved Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden force-pushed the jiden/downlaod-localization-11988 branch from 3f0c370 to c06351d Compare January 9, 2023 14:40
@msujew msujew merged commit 395ee0a into eclipse-theia:master Jan 9, 2023
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Jan 13, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants