Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to access language overrides with bracket syntax #12136

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Feb 1, 2023

What it does

Closes: #12129

In VSCode, it is possible to access language-overridden preferences using vscode.workspace.getConfiguration().get('[languageId]'). That has not been possible with the way preferences were being parsed in the PreferenceRegistryExtImpl. This PR adjusts the parsing routine to enable that style of access.

How to test

  1. Testcases have been added - if CI passes, the code is working as intended.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added preferences issues related to preferences vscode issues related to VSCode compatibility labels Feb 1, 2023
@msujew
Copy link
Member

msujew commented Feb 1, 2023

Is this related to #12129?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it works as expected 👍

  • the added unit-tests pass
  • the redhat.vscode-xml plugin (which makes use of the bracket syntax) activates

@colin-grant-work colin-grant-work merged commit 371ab02 into master Feb 9, 2023
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 9, 2023
@colin-grant-work colin-grant-work deleted the bugfix/overrides-with-brackets branch February 9, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedHat XML vscode extension stopped working from the latest Theia releases
3 participants