Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak in File System Watcher #12144

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix leak in File System Watcher #12144

merged 2 commits into from
Feb 7, 2023

Commits on Feb 3, 2023

  1. Don't repeatedly call Promise.race(). Fixes eclipse-theia#12001 

    The code was calling Promise.race() repeatedly while waiting for a file
to come into existence. This added a `PromiseReaction` object each time,
which never was collected

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
    @tsmaeder
    tsmaeder committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    38aa43b View commit details
    Browse the repository at this point in the history

  2. throw upon cancellation

    @paul-marechal
    paul-marechal committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9a8231d View commit details
    Browse the repository at this point in the history