Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve outlines for trees and select component #12156

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 7, 2023

What it does

I believe we used to have outlines for tree items, but I might have accidentally removed them in #11280. This PR adds them back.

It also removes the outlines for items in our select component, which seemed to have disappeared in the newest vscode version. VSCode has also increased the line-height for each individual option, so that's been done in this PR as well.

How to test

  1. Focus tree items in a tree view (navigator for example). Focused items should have a focus border around them
  2. Open select components such as the debug selector. The height and outlines of each individual option should resemble the style of vscode.
  3. Please test both of these changes with high contrast themes as well.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Feb 7, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Looks much better!

@msujew msujew merged commit 7f33d28 into master Feb 7, 2023
@msujew msujew deleted the msujew/outline-css-fixes branch February 7, 2023 14:52
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants