Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce plugin logging to debug level #12224

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Feb 24, 2023

What it does

At the moment, on startup and sometimes on shutdown, we log a separate message for various lifecycle events for every single plugin in the application. That's a lot of logs, most of which are completely uninformative. This PR converts them to debug level logs so that they are still available if they're of interest but won't be displayed routinely.

How to test

  1. Start the application.
  2. Everything should work as normal.
  3. There should be a couple hundred fewer lines in your log.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the plug-in system issues related to the plug-in system label Feb 24, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@colin-grant-work colin-grant-work merged commit e31a203 into eclipse-theia:master Mar 3, 2023
@colin-grant-work colin-grant-work deleted the feature/less-plugin-logging branch March 3, 2023 16:32
@colin-grant-work colin-grant-work added this to the 1.36.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants