Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12217 and the issue raised in #12212 .
The format of
OnEnterRule
had been defined withbeforeText
,afterText
, andpreviousLineText
as only strings. However they are often quasi-RegExp objects withpattern
andflags
string fields.How to test
*
appended inappropriately?Review checklist
Note: I've only tested on RHEL7, electron & browser modes, and a limited set of circumstances involving insertions of newlines.
Reminder for reviewers