Fix plugin proxy support #12266
Merged
Fix plugin proxy support #12266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, @msujew @erezmus @federicobozzini @CareyJWilliams can we cherry-pick and test this? |
1 task
This was referenced Mar 8, 2023
|
@thegecko Any update on this? I saw that you merged the fix into your fork. |
There was a problem hiding this comment.
Let's wait for @thegecko to confirm, but from what I have seen this fix works perfectly.
msujew
force-pushed
the
msujew/fix-proxy-support
branch
from
a2d5b5b
to
b5f4f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11911
Closes #12267
The actual fix for the issue is doing the following:
The function isn't supposed to return the original URL, but a proxied url or undefined. The current implementation broke http-requests in the plugin host if the proxy support for the plugin host wasn't turned off.
How to test
Repeat the testing steps from #11043 and confirm that nothing has regressed.
Also repeat the testing steps without a proxy in place.
Review checklist
Reminder for reviewers