Search-In-Workspace: Add multiselect functionality #12331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/MultiselectWorkspaceSearch
branch
from
4d5d9d8
to
3619538
Compare
FernandoAscencio
force-pushed
the
fa/MultiselectWorkspaceSearch
branch
from
3619538
to
697e006
Compare
msujew
approved these changes
Apr 3, 2023
|
Added handling for action buttons: "Replace" and |
FernandoAscencio
force-pushed
the
fa/MultiselectWorkspaceSearch
branch
2 times, most recently
from
05cd46c
to
829a1f2
Compare
FernandoAscencio
changed the title
delete keybind
FernandoAscencio
force-pushed
the
fa/MultiselectWorkspaceSearch
branch
from
829a1f2
to
9f64f03
Compare
|
@msujew can we merge this one? |
Closes eclipse-theia#11874 Implements in Search-In-Workspace: - Multiselect search results. - `delete` keybinding dismiss selected results. - `Ctrl`+`C` keybinding to copy selected results. - Handling for action buttons: `Replace` and `Dismiss` - `Replace` action in context menu with keybinding `enter` in replace-inputbox refreshes search results, instead of on every key. Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
vince-fugnitto
force-pushed
the
fa/MultiselectWorkspaceSearch
branch
from
9f64f03
to
ca5da30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11874
Implements in Search-In-Workspace:
deletekeybinding dismiss selected results.Ctrl+Ckeybinding to copy selected results.ReplaceandDismissReplaceaction in context menu with keybindingenterin replace-inputbox refreshes search results,instead of on every key.
How to test
The other context menu options have been made to work as close as possible to VS Code.
Review checklist
Reminder for reviewers