Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json schema URL #12376

Merged
merged 4 commits into from
May 8, 2023
Merged

Conversation

federicobozzini
Copy link
Contributor

What it does

It replaces the json schema used from https://schemastore.azurewebsites.net/api/json/catalog.json to https://www.schemastore.org/api/json/catalog.json. The first URL just redirects to the second one which is the canonical URL for the schema as shown in the official schema store page.
image

How to test

Check the network connections of the browser.

Review checklist

Reminder for reviewers

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Apr 12, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The URL update and extensibility updates look good

@JonasHelming
Copy link
Contributor

@federicobozzini @vince-fugnitto I wonder whether we could get somehow rid of this. We recently investigated the network traffic of Theia and this is the only call Theia actually does. (I am fine with this change though, should we merge it?)

@vince-fugnitto
Copy link
Member

I wonder whether we could get somehow rid of this. We recently investigated the network traffic of Theia and this is the only call Theia actually does. (I am fine with this change though, should we merge it?)

@JonasHelming the proposal in the past was to do the following #11881, I'm not sure if it is feasible at the moment to completely remove it but you can investigate.

@vince-fugnitto vince-fugnitto modified the milestone: 1.37.0 Apr 27, 2023
@federicobozzini
Copy link
Contributor Author

Can we merge this in the meanwhile as an improvement over the current state of things?

@JonasHelming
Copy link
Contributor

From my POV: yes!

@tsmaeder tsmaeder merged commit 83c29fd into eclipse-theia:master May 8, 2023
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants