-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable workspace file extension customization #12420
Conversation
@msujew what problem is this solving? As far as I know we can't load any other types of workspace file anyway, right? |
@tsmaeder The reasoning behind this PR isn't to change the workspace file format, but to allow adopters to specifiy their own file extensions. Right now, it's hard coded to be either See also this question we had on the discourse forum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the code and it seems O.K. I'm just wondering whether it would make more sense to model this as "a list of extensions, one of which is the default" instead of "the default extension plus possibly VS Code".
f0e6505
to
c7813a9
Compare
@tsmaeder Thanks for the feedback. I've adapted the PR to include a simple array of workspace file options, with the first one just being the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some people are never satisfied ;-) Just one more suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
0b75251
to
c02d5a3
Compare
I cancelled an old pending review and GH decided to publish it... Don't mind me. |
What it does
As of now, only
.theia-workspace
and.code-workspace
files are supported when selecting/creating workspace files. This change allows to easily customize the workspace file extension and also to exclude.code-workspace
files.How to test
WorkspaceFileService#getWorkspaceFileTypes
method to return a different array.Review checklist
Reminder for reviewers