quick-open: Esc closes inputbox when focus out.
#12446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/EscFunctionality
branch
4 times, most recently
from
b70c268
to
69112d1
Compare
packages/core/src/browser/quick-input/quick-command-frontend-contribution.ts
Show resolved
Hide resolved
packages/core/src/browser/quick-input/quick-command-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
| @@ -38,6 +38,9 @@ export class QuickCommandFrontendContribution implements CommandContribution, Ke | |||
| commands.registerCommand(CLEAR_COMMAND_HISTORY, { | |||
| execute: () => commands.clearCommandHistory(), | |||
| }); | |||
| commands.registerCommand({ id: 'workbench.action.closeQuickOpen' }, { | |||
There was a problem hiding this comment.
minor - refactor the command to a constant (since it is referenced multiple times)?
export const CLOSE_QUICK_OPEN: Command = {
id: 'workbench.action.closeQuickOpen'
}It can live under packages/core/src/browser/quick-input/quick-command-service.ts
There was a problem hiding this comment.
Got it. I'll squash the commits while I am at it.
FernandoAscencio
force-pushed
the
fa/EscFunctionality
branch
from
9f072e9
to
5acf720
Compare
Closes: 6773 Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com> Co-Authored-By: vince-fugnitto <vincent.fugnitto@ericsson.com>
FernandoAscencio
force-pushed
the
fa/EscFunctionality
branch
from
5acf720
to
d61114d
Compare
vince-fugnitto
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #6773
When notifications are showing the
esckey will close those first before closing the quick input box. This behavior is consistent with VS Code.How to test
esckeyReview checklist
Reminder for reviewers